Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backgrounding crash fix #63

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Backgrounding crash fix #63

merged 1 commit into from
Oct 12, 2023

Conversation

davidjiagoogle
Copy link
Collaborator

A better fix than #58

When camera is flipped, it is not assigned to a runningCameraJob, this caused the CorotineCameraProvider to not be able to unbind camera on job cancelled

Copy link
Collaborator

@temcguir temcguir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This looks pretty fragile, so we should probably have a test for backgrounding the app and returning using Espresso. But that can be a separate PR.

@davidjiagoogle davidjiagoogle merged commit 48cc7b1 into main Oct 12, 2023
3 checks passed
@davidjiagoogle davidjiagoogle deleted the david/backgroundCrashFix branch October 12, 2023 21:12
@temcguir temcguir linked an issue Oct 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalStateException after backgrounding and coming back to the app
2 participants